Project `path` and `name` possibly conflated in RSpec tests
In !20610 (merged), it was discovered that a test for Project
accidentally used name
instead of path
.
In this case, [changing the
path
] helped identify that this test was incorrectly usingname
where it should have been usingpath
.🙂
We might want to think about explicitly using a
path
in our factories that looks noticeably different from thename
to prevent this kind of test error. WDYT?
This would involve a tiny change to the factory (e.g. a space between "project" and the sequence number, or appending path
to the path):
factory :project, class: 'Project' do
sequence(:name) { |n| "project#{n}" }
path { name.downcase.gsub(/\s/, '_') }
...and will possibly result in a significant number of broken tests. I think this change will mean our test suite will avoid potential false positives.