Ruby 3 syntax expectation failure ee/spec/controllers/registrations/groups_projects_controller_spec.rb
Job #3017757607 failed for 465b2f7f:
Failures:
1) Registrations::GroupsProjectsController POST #create with an authenticated user when in the trial onboarding flow when trial is in the foreground applies a trial
Failure/Error: return yield unless new(admin).admin_mode?
#<GitlabSubscriptions::ApplyTrialService:0x00007fa6b1d3b850> received :execute with unexpected arguments
expected: ({:trial_user=>#<ActionController::Parameters {"glm_source"=>"about.gitlab.com", "glm_content"=>"conte...", "namespace_id"=>2354, "gitlab_com_trial"=>true, "sync_to_gl"=>true} permitted: true>, :uid=>1437})
got: ({:trial_user=>#<ActionController::Parameters {"glm_source"=>"about.gitlab.com", "glm_content"=>"conte...", "namespace_id"=>2354, "gitlab_com_trial"=>true, "sync_to_gl"=>true} permitted: true>, :uid=>1437})
# ./ee/app/controllers/registrations/groups_projects_controller.rb:170:in `apply_trial'
# ./ee/app/controllers/registrations/groups_projects_controller.rb:84:in `create_with_new_group_flow'
# ./ee/app/controllers/registrations/groups_projects_controller.rb:45:in `create'
# ./ee/lib/gitlab/ip_address_state.rb:10:in `with'
# ./ee/app/controllers/ee/application_controller.rb:45:in `set_current_ip_address'
# ./lib/gitlab/auth/current_user_mode.rb:72:in `with_current_admin'
# ./app/controllers/application_controller.rb:534:in `set_current_admin'
# ./lib/gitlab/session.rb:11:in `with_session'
# ./app/controllers/application_controller.rb:522:in `set_session_storage'
# ./lib/gitlab/i18n.rb:107:in `with_locale'
# ./lib/gitlab/i18n.rb:113:in `with_user_locale'
# ./app/controllers/application_controller.rb:516:in `set_locale'
# ./app/controllers/application_controller.rb:510:in `set_current_context'
# ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:87:in `block (3 levels) in <main>'
# ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:370:in `block (6 levels) in <main>'
# ./spec/spec_helper.rb:442:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:433:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:429:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:56:in `with_raw_context'
# ./spec/spec_helper.rb:429:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:266:in `block (2 levels) in <top (required)>'
# ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
# ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
2) Registrations::GroupsProjectsController POST #create with an authenticated user when in the trial onboarding flow when trial is in the foreground when failing to apply trial logs an error
Failure/Error: return yield unless new(admin).admin_mode?
#<GitlabSubscriptions::ApplyTrialService:0x00007fa6aed6c2f0> received :execute with unexpected arguments
expected: ({:trial_user=>#<ActionController::Parameters {"glm_source"=>"about.gitlab.com", "glm_content"=>"conte...", "namespace_id"=>2354, "gitlab_com_trial"=>true, "sync_to_gl"=>true} permitted: true>, :uid=>1437})
got: ({:trial_user=>#<ActionController::Parameters {"glm_source"=>"about.gitlab.com", "glm_content"=>"conte...", "namespace_id"=>2354, "gitlab_com_trial"=>true, "sync_to_gl"=>true} permitted: true>, :uid=>1437})
# ./ee/app/controllers/registrations/groups_projects_controller.rb:170:in `apply_trial'
# ./ee/app/controllers/registrations/groups_projects_controller.rb:84:in `create_with_new_group_flow'
# ./ee/app/controllers/registrations/groups_projects_controller.rb:45:in `create'
# ./ee/lib/gitlab/ip_address_state.rb:10:in `with'
# ./ee/app/controllers/ee/application_controller.rb:45:in `set_current_ip_address'
# ./lib/gitlab/auth/current_user_mode.rb:72:in `with_current_admin'
# ./app/controllers/application_controller.rb:534:in `set_current_admin'
# ./lib/gitlab/session.rb:11:in `with_session'
# ./app/controllers/application_controller.rb:522:in `set_session_storage'
# ./lib/gitlab/i18n.rb:107:in `with_locale'
# ./lib/gitlab/i18n.rb:113:in `with_user_locale'
# ./app/controllers/application_controller.rb:516:in `set_locale'
# ./app/controllers/application_controller.rb:510:in `set_current_context'
# ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:87:in `block (3 levels) in <main>'
# ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:380:in `block (7 levels) in <main>'
# ./spec/spec_helper.rb:442:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:433:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:429:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:56:in `with_raw_context'
# ./spec/spec_helper.rb:429:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:266:in `block (2 levels) in <top (required)>'
# ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
# ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
Finished in 5.32 seconds (files took 1 minute 3.06 seconds to load)
2 examples, 2 failures
Failed examples:
rspec ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:369 # Registrations::GroupsProjectsController POST #create with an authenticated user when in the trial onboarding flow when trial is in the foreground applies a trial
rspec ./ee/spec/controllers/registrations/groups_projects_controller_spec.rb:376 # Registrations::GroupsProjectsController POST #create with an authenticated user when in the trial onboarding flow when trial is in the foreground when failing to apply trial logs an error
Edited by Luke Duncalfe