Container Scanning Baseline vulnerabilities are shown in the MR
Summary
Vulnerabilities that are part of the baseline (already in default branch) are still being shown in the MR Widget.
Steps to reproduce
In a project that has security issues:
- Scan the default branch so the Vulnerability Report is populated.
- Create a new MR based on the default branch
- Edit something so a new pipeline is triggered
- Result: all the findings are shown for Container Scanning
Example Project
Project: https://gitlab.com/kgoossens-group/kas/simple-notes Sample MR: https://gitlab.com/kgoossens-group/kas/simple-notes/-/merge_requests/7
What is the current bug behavior?
What is the expected correct behavior?
Relevant logs and/or screenshots
While the vulnerabilities where already in the baseline:
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
-
backend in ee/lib/gitlab/ci/parsers/security/validators/default_branch_image_validator.rb
check for the partial name of the image (without revision) when checking if given vulnerabilities for given image exists in the project,
Edited by Alan (Maciej) Paruszewski