Add a new danger rule to prevent adding new metrics to UsageData class
Since we deprecated adding new metrics directly to usage_data.rb
we use instrumentation classes instead.
It would be beneficial to add a new Danger rule to prevent adding new code to usage_data
(but it should allow to modify the existing code to allow bugs fixing for example).
For example, changes like:
+ ci_runners: count(::Ci::Runner),
shouldn't be allowed, while:
- ci_runners: count(::Ci::Runner),
+ ci_runners: count(::Ci::NewRunner),
are fine.
This will potentially save a lot of time to other developers. And will simplify product intelligence review process
See the linked thread below for an example:
-
@nbelokolodov started a discussion: (+3 comments) sorry, missed these changes. We dont add metrics to
usage_data.rb
anymore.Just adding metrics definitions files is enough to add the values to ServicePing payload
so just please remove these changes (and from
ee
one as well), like