Improve SaaS testing and linting of ee vs ce code
Plan
-
Move metadata of :saas
to foss in order to leverage it there - !112833 (merged) -
Make data-testid
a helper for rspec tests - !129391 (merged) -
Enable :saas_registration
metadata in tests to automatically include:saas
metadata - !112861 (merged) -
Explore linting for code placement for foss extended into ee vs standalone
Click to expand
The following discussion from !100466 (merged) should be addressed:
-
@dstull started a discussion: (+5 comments) issue:
If this is not a
prepended
(extended) class fromfoss
, then it should live underee/app/models/preloaders/user_member_roles_in_projects_preloader.rb
instead(models/preloaders
instead ofmodels/ee/preloaders
) and not need thismodule EE
line seeee/app/models/preloaders/environments/protected_environment_preloader.rb
for an example.side thought - we need to build better mouse trap in some way for this...some kindof linter as it should be programmatically possible to lint this.
Edited by Doug Stull