Global Search Error Budget improvement: indexing SLO fix
Currently, we have a lot of alerts from SidekiqServiceGlobalSearchIndexingApdexSLOViolation
violations. Most likely this happens because we average out initial and incremental indexing, which have very different timings and a lot of variability.
The suggestion is to:
- Start treating wikis as code (since code & wikis are both handled by
gitlab-elasticsearch-indexer
). Line to update - Bump up
CODE_INDEXING_TARGET_S
to a higher number to account for those indexing peaks.
This can be our first iteration. A long term option can be to separate initial and incremental indexing (@john-mason 's idea) or possibly to calculate indexing throughput in bytes/second.
@rzwambag @changzhengliu @terrichu @john-mason @maddievn @sdungarwal WDYT?