Metric images tab missing from alert detail view
Summary
The metric images tab is missing on the alert management screen. As a result, it's no longer possible to view, add or delete metric images.
This was caused when !102669 (merged) was merged, during %15.7.
This causes an additional issue whereby the routes are off by one, leading to this separately raised bug: #384067 (closed).
Most likely, both issues will be fixed with the same fix.
Steps to reproduce
- Navigate to the alert management page and view an alert.
- Regard the tabs underneath the alert title.
Example Project
What is the current bug behavior?
- There are two tabs - Alert Details and Activity feed.
screenshot |
---|
What is the expected correct behavior?
- There are three tabs - Alert Details, Metrics and Activity feed.
screenshot |
---|
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
As of opening the issue - this is only present on GitLab.com. Self-hosted environments would not have the bug yet.
Possible fixes
- Update alert_details.vue
Before:
<metric-images-tab
:data-testid="$options.tabsConfig[1].id"
:title="$options.tabsConfig[1].title"
/>
After:
<gl-tab :title="$options.tabsConfig[1].title">
<metric-images-tab :data-testid="$options.tabsConfig[1].id" />
</gl-tab>
- Add a test to the alert details page to verify that the metrics images tab is shown.
-
Note: this test actually exists and passes because the component is mounted, but in practice the html is hidden by
<gl-tabs>
because it's not wrapped by<gl-tab/>
as it should be. So a better test would be to check for something more concrete, e.g. check that the tab titles are all correct and present.
-
Note: this test actually exists and passes because the component is mounted, but in practice the html is hidden by
Edited by Tristan Read