500 error when you click the help icon in Suggested Reviewers and then don’t assign any reviewer
Summary
Error displayed in UI when clicking within Suggested Reviewers box (on the tooltip) and then clicking out of it which triggers a save of the reviewers. Also the tooltip doesn't seem to link to the help page.
Steps to reproduce
- Open any MR with suggested reviewers and does not currently have any reviewers assigned
- Edit Reviewers
- click tool tip (?)
- Click out of reviewers
Example Project
any MR with suggested reviewers and does not currently have any reviewers assigned
What is the current bug behavior?
500 error
What is the expected correct behavior?
Nothing
Relevant logs and/or screenshots
Request payload: {"merge_request":{"reviewer_ids":[null],"suggested_reviewer_ids":[]}}
Request URL: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/105989.json?serializer=sidebar_extras
Request Method: PUT
Status Code: 500
unknown attribute 'suggested_reviewer_ids' for MergeRequest.
app/services/issuable_base_service.rb:293:in `update',
app/services/merge_requests/base_service.rb:114:in `update',
app/services/merge_requests/update_service.rb:94:in `general_fallback',
ee/app/services/ee/merge_requests/update_service.rb:18:in `general_fallback',
app/services/merge_requests/update_service.rb:18:in `execute',
app/controllers/projects/merge_requests_controller.rb:273:in `update',
ee/lib/gitlab/ip_address_state.rb:10:in `with',
ee/app/controllers/ee/application_controller.rb:46:in `set_current_ip_address',
app/controllers/application_controller.rb:537:in `set_current_admin',
lib/gitlab/session.rb:11:in `with_session',
app/controllers/application_controller.rb:528:in `set_session_storage'
Results of GitLab environment info
gitlab.com next
Edited by Jay McCure