Find a convention for using loading counts
The following discussion from !104068 (merged) should be addressed:
-
@dftian started a discussion: (+3 comments) thought: I think this is fine because we don't really have a good variable name to succinctly describe what this is, but it's caused confusion in the past because aside from one other place, our team is the only team that uses it. WDYT about
loadingCount
, since it's a number? I'm cool with either way.
Implementation plan
-
Find all occurrences of loadingKey
(GraphQL property) for the security dashboards / vulnerability reports and replace them with the$apollo.queries.queryName.loading
property.
Verification steps
There are a couple of components involved and the steps are grouped per place where you can the components.
vulnerability_finding_modal.vue
- go to lorenzvanherwaarden/security-reports pipelines
- set network throttling to slow 3G
- click on any finding
- verify that modal shows loading state for a while
cluster_filter.vue & image_filter.vue
- set network throttling to slow 3G
- go to gitlab vulnerability report page operational tab (feature flag refactor_vulnerability_filters is enabled here)
- verify that both image and cluster filters show loading state for a while
cluster_filter_deprecated.vue & image_filter_deprecated.vue
This must be tested locally because the feature flag refactor_vulnerability_filters
needs to be false but is already true globally on production.
- disable refactor_vulnerability_filters feature flag
echo "Feature.disable(:refactor_vulnerability_filters)" | rails c
- set network throttling to fast 3G
- go to the vulnerability report page of security-reports on the operational vulnerabilities tab (need to refresh on this tab specifically, because it is already loaded when you're on the other tab, so you wouldn't notice the loading)
- verify that both cluster and image filter show loading state for a while
tool_filter.vue
This must be tested locally, because the feature flag refactor_vulnerability_tool_filter
must be enabled on a group with ultimate license (to see vulnerability report on group level), and I can't create a group with ultimate license for demo purposes.
- enable refactor_vulnerability_tool_filter feature flag
echo "Feature.enable(:refactor_vulnerability_tool_filter)" | rails c
- set network throttling to fast 3G
- go to the vulnerability report page of flightjs group
/groups/flightjs/-/security/vulnerabilities
(or other group with vulnerability report) - verify that the tool filter shows loading state for a while