Validations failing on long tokens for DroneCI Integrations
Summary
Entering over 100 characters into the token field for the DroneCI integrations results in "Validations failed" when selecting "Test" for GitLab 15+, and will not create the integration.
Working as expected on GitLab 14 with long tokens.
Also seems to produce "Connection successful" despite entering an inaccessible URL in the Drone Server URL field.
Steps to reproduce
- Create a new project
- Select Integrations under settings
- Enter any URL in the URL field, starting with
http://
orhttps://
- Enter a token over 100 characters
- Select
Test settings
The same workflow with any a token less than 100 characters returns Connection successful
Example Project
What is the current bug behavior?
In any project, on version GitLab 15+, Drone validations fail if the token is over 100 characters
What is the expected correct behavior?
Should accept long tokens, as was working in GitLab 14 (unsure if this worked prior to 14)
Relevant logs and/or screenshots
{"error":true,"message":"Validations failed.","service_response":"","test_failed":false}
Output of checks
This bug happens on GitLab.com /label reproduced on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) System information System: Ubuntu 20.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.7.6p219 Gem Version: 3.1.6 Bundler Version:2.3.15 Rake Version: 13.0.6 Redis Version: 6.2.7 Sidekiq Version:6.5.7 Go Version: unknown GitLab information Version: 15.6.1-ee Revision: fe39c71ac74 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 13.8 URL: HTTP Clone URL: SSH Clone URL: Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.13.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)