Update integrations field logic to support new method for secret types
Per the discussion in !104888 (comment 1214132489), the purpose of this issue is to capture the follow-up tasks to convert the integrations field logic to explicitly declare secret-type fields instead of the existing auto conversion.
Proposal
- Change the default value for of
is_secret
tofalse
inapp/models/integrations/field.rb
and update the relevant fields:
def initialize(name:, integration_class:, type: 'text', is_secret: true, api_only: false, **attributes)
# ..
attributes[:type] = is_secret ? 'password' : type
- Update all secret fields from
app/models/integrations/*
which satisfies the following condition:
SECRET_NAME.match?(field_name)
- Update the
app/models/integrations/apple_app_store.rb
by removingis_secret: false
code.
/cc @bmarjanovic
Edited by Bojan Marjanovic