Skip to content

Searching for commits in the repository commits page fails when trailing spaces exist

Summary

When you paste a commit title, sometimes trailing spaces can be included.

The query is affected by this invisible character and will return empty.

This increases in change, because when you copy the heading on the Commit details page, it's easy to include a space.

Steps to reproduce

  1. Go to a commit page of a commit in default branch.
  2. Copy the title of the commit.
  3. Go to the repository commits page of default branch.
  4. Paste the commit title into the search box.
  5. See that no results are returned.
  6. Delete the trailing space.
  7. See the commit being shown.

Example Project

gitlab-org/gitlab, any really.

What is the current bug behavior?

Search returns empty.

What is the expected correct behavior?

Search returns the desired commit.

Relevant logs and/or screenshots

Copying the heading in commits page

Screenshot_2022-12-21_at_15.05.00

Searching for it

Screenshot_2022-12-21_at_15.05.39

Expected (without trailing space)

Screenshot_2022-12-21_at_15.06.05

Possible fixes

Some options:

  1. Trim the query string, to avoid trailing and leading spaces?

and/or

  1. Add an easy way to copy the title of the commit in the Commits page (copy to clipboard?)
    1. Or even a button to "Is this commit on branch: [________]"
Edited by André Luís