Move EE JavaScript tests to their own respective directory
Plan:
-
Modify spec/javascripts/test_bundle.js
to runee/spec/javascripts
tests as well asspec/javascripts
=> https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6184 -
Move EE-specific JS tests to ee/spec/javascripts
, by bulk:
-
spec/javascripts/add_gitlab_slack_application
=> !6454 (merged) -
spec/javascripts/approvals
=> !6454 (merged) -
spec/javascripts/approvers_select_spec.js
=> !6454 (merged) -
spec/javascripts/boards
=> !6606 (merged) -
spec/javascripts/ci_variable_list
=> !6454 (merged) -
spec/javascripts/ee
=> !6655 (merged) -
spec/javascripts/ee/boards/models/list_spec.js
-
spec/javascripts/environments
=> !6454 (merged) -
spec/javascripts/epics
=> !6655 (merged) -
spec/javascripts/filtered_search
=> !6454 (merged) -
spec/javascripts/fixtures
=> !6454 (merged) -
spec/javascripts/geo_nodes
=> !6655 (merged) -
spec/javascripts/group_member_contributions
=> !6663 (merged) -
spec/javascripts/issuable
=> !6663 (merged) -
spec/javascripts/jobs/shared_runner_limit_block_spec.js
-
spec/javascripts/kubernetes_logs_spec.js
=> !6454 (merged) -
spec/javascripts/monitoring/alert_widget_form_spec.js
-
spec/javascripts/monitoring/alert_widget_spec.js
-
spec/javascripts/multiple_assignees
=> !6454 (merged) -
spec/javascripts/pipelines
=> !6663 (merged) -
spec/javascripts/projects
=> !6454 (merged) -
spec/javascripts/prometheus_metrics
=> !6454 (merged) -
spec/javascripts/roadmap
=> !6663 (merged) -
spec/javascripts/sidebar
=> !6663 (merged) -
spec/javascripts/vue_mr_widget/ee_mr_widget_options_spec.js
-
spec/javascripts/vue_shared
=> !6663 (merged)
-
Make -f
great again and get it working with the ee directory: =>
The following commands can be adapted and used to move files easily:
› git diff ce/master..HEAD --name-status --diff-filter=A -- spec/javascripts | cut -f2 | xargs -t -L1 -I % dirname % | xargs -t -L1 -I % mkdir -p ee/%
› git diff ce/master..HEAD --name-status --diff-filter=A -- spec/javascripts | cut -f2 | xargs -t -L1 -I % git mv % ee/%
The following discussion from !3194 (merged) should be addressed:
Previous description
@iamphill said:
@smcgivern @godfat We could make it work with a bit of a tweak to the karma config
See https://gitlab.com/gitlab-org/gitlab-ee/blob/master/config/karma.config.js#L39 we could just change that slightly or add in
spec/ee/
This is part of https://gitlab.com/gitlab-org/gitlab-ee/issues/3107
Edited by Rémy Coutable