Move data definition from HAML app/views/projects/artifacts/index.html.haml to ArtificatsHelper helper
The following discussion from !104465 (merged) should be addressed:
-
@splattael started a discussion: Suggestion (non-blocking) Since the data attributes gets longer, more complex, and harder to read I wonder if we should extract this into helper.
🤔 This has the following benefits:
- Easier to read
- No inline Hash/JSON definition
- Easier to test
- We'll add a helper spec to test all possible states
- This helper spec can use
build_stubbed
to avoid creating database records (see #374088 (closed)) - The controller spec can be slimmed down again as we don't need to test all possible the states anymore
Edit: I'll create a follow-up.
- Easier to read
Proposal
-
create a new app/helpers/artifacts_helper.rb
and refactorapp/views/projects/artifacts/index.html.haml
to use it instead -
create a new spec/helpers/artifacts_helper_spec.rb
to test the helper's functionality -
adapt and consider cutting back other tests for this feature now that the helper does more of the work (and the helper spec provides more specific test coverage)
Edited by Miranda Fluharty