Branch rules ignore that approval rules are a premium feature
Summary
Branch rules show approval rules with required approvers and status checks in projects that are in the GitLab Free plan although these are GitLab Premium or GitLab Ultimate features.
In the MR, however, the approval is optional
Steps to reproduce
- take a premium project and add branch rules that are part of the premium tier
- Change to the free tier
- observe that the premium features are still visible in the branch rules overview and and branch rules detail view
Example project that used to be premium and is now free
Go to this group with is in the free plan and then to this project in that group.
Observe that approval is required for specific branches although this is a ~"GitLab Premium" feature. Likewise are status checks shown that are a ~"GitLab Ultimate" feature
Likewise in the Branch Rules overview we see status checks and approval rules listed:
In the MR, these features are not applied which is correct (although I am not 100% sure if the status checks simply failed or if they were not applied):
What is the current bug behavior?
Premium and Ultimate features are shown
What is the expected correct behavior?
Premium and Ultimate features should not be shown