Cleanup in the welcome controller
While working on #371638 (closed) and from discussions in !107302 (comment 1276680298)
After some local testing it was found that we have some code paths that aren't executed, specifically:
app/controllers/registrations/welcome_controller.rb
def requires_confirmation?(user)
return false if user.confirmed?
return false unless Gitlab::CurrentSettings.email_confirmation_setting_hard?
true
end
def path_for_signed_in_user(user)
return users_almost_there_path(email: user.email) if requires_confirmation?(user)
stored_location_for(user) || members_activity_path(user.members)
end
This wasn't cleaned up in the mentioned MR as other areas reference this area of the code
Edited by Jay Montal