Follow-up from "Initialise collapsible super sidebar"
The following discussions from !110868 (merged) should be addressed:
-
@markrian started a discussion: (+4 comments) Add tests for the state manager
-
@markrian started a discussion: nitpick: This could be simplified to not call the function twice:
findToggle()?.addEventListener('click', () => { const value = !isCollapsed(); toggleSuperSidebarCollapsed(value, true); });
Alternatively:
const toggle = findToggle(); if (toggle) { toggle.addEventListener('click', () => { const value = !isCollapsed(); toggleSuperSidebarCollapsed(value, true); }); }
-
@markrian started a discussion: (+1 comment) thought: Is there a plan to add an clickable overlay to hide the sidebar when on mobile? This is the behaviour of the existing sidebar:
-
@markrian started a discussion: suggestion (non-blocking): Should this be
super-sidebar-width
?padding-left: $super-sidebar-width;
-
@markrian started a discussion: suggestion (non-blocking): WDYT of moving these two utilities into the definition of the
super-sidebar
class?Or is there a reason not to?