If MR diff is not ready, Changes page has never ending spinner "Building your MR"
Summary
As surfaced by this automated test: #398550 (closed) (this occurred on gitlab.com)
As we now load diffs asynchronously, if a user navigates to the Changes tab of an MR before they are available an error will be displayed and a never ending spinner will occur. The user must refresh the page to see the diff.
I have seen this occur manually but I am not sure how likely it is to occur. It is quite frequent with the automated E2E tests as they are quick to navigate to MRs that have just been created.
Ideally the diff eventually loads on the page without having to refresh.
Steps to reproduce
- Create MR via API (the larger the more likely this issue will occur)
- Immediately navigate to changes tab
Example Project
Any
What is the current behavior?
Warning displayed, user has to refresh page.
What is the expected desired behavior?
Diff eventually loads without having to refresh the page
Availability and Testing
Regression testing, please make sure e2e:package-and-test job is passing. @jay_mccure to update E2E tests to not refresh the page