Skip to content

merge_request_tabs.js > Cleanup computeTopOffset logic

The following discussion from !116820 (merged) should be addressed:

  • @pgascouvaillancourt started a discussion: (+2 comments)

    thought: I'm wondering if we could simplify the call to initDiffStatsDropdown in app/assets/javascripts/merge_request_tabs.js. There's a computeTopOffset function there that might not need to do what it does anymore, now that we calculate the offset here.

In !116820 (merged), we have revisited some sticky headers' behavior which might give us an opportunity to cleanup some code in app/assets/javascripts/merge_request_tabs.js.