Follow-up from "Add pagination to protected environments"
-
@pgascouvaillancourt started a discussion: nitpick(non-blocking): A small edge-case I noticed when unprotecting an environment is that, it it's the last of a given page, the page remains active even though it's empty. Navigating to another page causes the
pageInfo
to be updated. Perhaps we should automatically load the previous page when the current one is emptied?
Proposed Solution:
- When unprotecting an environment - automatically load the previous page, when the current one has no environments left on it.
Implementation guide
Within the unprotectEnvironment
action, in the .then
callback for the
deleteProtectedEnvironment
call, we should check if there are any protected
environments left. If not, and the current page is greater than 1
, then
dispatch the setPage
action with the current page (available in
state.pageInfo.page
) reduced by 1.
Testing for this behaviour should be added to
ee/spec/frontend/protected_environments/store/edit/actions_spec.js