[Feature flag] Roll out `ci_job_failures_in_mr`

Summary

This issue is to rollout ci_job_failures_in_mr which does not have an issue link. The reason is simple: this was developped during our Verify:Ops hackathon.

Owners

• Team: Pipeline Authoring
• Most appropriate slack channel to reach out to: #g_pipeline_authoring
• Best individual to reach out to: @f_caplette
• PM: @dhershkovitch

Expectations

What are we expecting to happen?

This Feature flag adds a link under each pipeline in the merge request pipelines tabs "show failed jobs". Clicking on it will show all the failed jobs of that pipeline. Then, each job can be expanded to see the job log.

When is the feature viable?

As soon as the ff is enabled.

What might happen if this goes wrong?

The worst possible outcome is an issue with polling jobs failures that would result in a performance regression while in the MR-> pipelines tab.

Rollout Steps

Note: Please make sure to run the chatops commands in the slack channel that gets impacted by the command.

Rollout on non-production environments

• Verify the MR with the feature flag is merged to master.
• Verify that the feature MRs have been deployed to non-production environments with:
  • /chatops run auto_deploy status <merge-commit-of-your-feature>
• Enable the feature globally on non-production environments.
  • /chatops run feature set ci_job_failures_in_mr true --dev --staging --staging-ref
  • If the feature flag causes QA end-to-end tests to fail:
    • Disable the feature flag on staging to avoid blocking deployments.
• Verify that the feature works as expected. Posting the QA result in this issue is preferable. The best environment to validate the feature in is staging-canary as this is the first environment deployed to. Note you will need to make sure you are configured to use canary as outlined here when accessing the staging environment in order to make sure you are testing appropriately.

For assistance with QA end-to-end test failures, please reach out via the #quality Slack channel. Note that QA test failures on staging-ref don't block deployments.

Specific rollout on production

For visibility, all /chatops commands that target production should be executed in the #production slack channel and cross-posted (with the command results) to the responsible team's slack channel (#g_TEAM_NAME).

• Ensure that the feature MRs have been deployed to both production and canary.
  • /chatops run auto_deploy status <merge-commit-of-your-feature>
• Depending on the type of actor you are using, pick one of these options:
  • If you're using project-actor, you must enable the feature on these entries:
    • /chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com ci_job_failures_in_mr true
• Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable.

Preparation before global rollout

• Set a milestone to the rollout issue to signal for enabling and removing the feature flag when it is stable.
• Check if the feature flag change needs to be accompanied with a change management issue. Cross link the issue here if it does.
• Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the @sre-oncall Slack alias.
• Ensure that documentation has been updated (More info).
• Leave a comment on [the feature issue][main-issue] announcing estimated time when this feature flag will be enabled on GitLab.com.
• Ensure that any breaking changes have been announced following the release post process to ensure GitLab customers are aware.
• Notify #support_gitlab-com and your team channel (more guidance when this is necessary in the dev docs).
• Ensure that the feature flag rollout plan is reviewed by another developer familiar with the domain.

Global rollout on production

For visibility, all /chatops commands that target production should be executed in the #production slack channel and cross-posted (with the command results) to the responsible team's slack channel (#g_TEAM_NAME).

• Incrementally roll out the feature.
  • Between every step wait for at least 15 minutes and monitor the appropriate graphs on https://dashboards.gitlab.net.
  • If the feature flag in code has an actor, perform actor-based rollout.
    • /chatops run feature set ci_job_failures_in_mr 25 --actors
    • /chatops run feature set ci_job_failures_in_mr 50 --actors
    • /chatops run feature set ci_job_failures_in_mr 75 --actors
    • /chatops run feature set ci_job_failures_in_mr 100 --actors
  • Enable the feature globally on production environment.
    • /chatops run feature set <feature-flag-name> true
• Observe appropriate graphs on https://dashboards.gitlab.net and verify that services are not affected.
• Leave a comment on [the feature issue][main-issue] announcing that the feature has been globally enabled.
• Wait for at least one day for the verification term.

Release the feature

After the feature has been deemed stable, the clean up should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase.

You can either create a follow-up issue for Feature Flag Cleanup or use the checklist below in this same issue.

• Create a merge request to remove ci_job_failures_in_mr feature flag. Ask for review and merge it.
  • Remove all references to the feature flag from the codebase.
  • Remove the YAML definitions for the feature from the repository.
  • Create a changelog entry.
• Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before the monthly release was tagged, the feature can be officially announced in a release blog post.
  • /chatops run release check <merge-request-url> <milestone>
• Close [the feature issue][main-issue] to indicate the feature will be released in the current milestone.
• Clean up the feature flag from all environments by running these chatops command in #production channel:
  • /chatops run feature delete ci_job_failures_in_mr --dev --staging --staging-ref --production
• Close this rollout issue.

Rollback Steps

• This feature can be disabled by running the following Chatops command:

/chatops run feature set ci_job_failures_in_mr false