Move BroadcastMessage under `System` module
Summary
Currently this violates the rubocop
❯ be rubocop app/models/broadcast_message.rb
Inspecting 1 file
C
Offenses:
app/models/broadcast_message.rb:3:7: C: Gitlab/NamespacedClass: Classes must be declared inside a module indicating a product domain namespace. For more info: https://gitlab.com/gitlab-org/gitlab/-/issues/321982
class BroadcastMessage < MainClusterwide::ApplicationRecord
^^^^^^^^^^^^^^^^
After discussion in internal slack we think the best module for this would be System
for general items and then items that tie to changing at view/controller/API layer to Admin
.
Plan
-
Move app/models/broadcast_message.rb
to/app/models/system/broadcast_message.rb
-
Move ee/app/models/ee/broadcast_message.rb
toee/app/models/ee/system/broadcast_message.rb
-
Move app/helpers/broadcast_messages_helper.rb
toapp/helpers/admin/broadcast_messages_helper.rb
-
Move lib/api/broadcast_messages.rb
tolib/api/admin/broadcast_messages.rb
- do not change the route -
Move lib/api/entities/broadcast_message.rb
tolib/api/entities/system/broadcast_message.rb
-
All related spec files to the items above
Edited by Ross Byrne