CSP blocks certain URLs on sign-up/registration flows that should be allowed to go through
Summary
The URLs https://www.google.com/pagead/landing
and https://pagead2.googlesyndication.com/pagead/landing
are being blocked by the CSP. @dennischarukulvanich validated that we expect those calls to go through "within the account signups and trial registrations flow". We need to add those URLs to the connect-src
directive of the CSP on those pages.
Steps to reproduce
Visit the sign in page without being logged in and you can observe the blocked URLs in your browser's dev tools' network tab.
Example Project
What is the current bug behavior?
Requests to https://www.google.com/pagead/landing?...
and https://pagead2.googlesyndication.com/pagead/landing?...
are blocked
What is the expected correct behavior?
Requests to https://www.google.com/pagead/landing?...
and https://pagead2.googlesyndication.com/pagead/landing?...
should go through within the account signups and trial registrations flow.
Relevant logs and/or screenshots
Sentry reports:
- https://new-sentry.gitlab.net/organizations/gitlab/issues/220324/?environment=gprd&project=4&query=Blocked+%27connect%27+from&referrer=issue-stream&sort=freq&statsPeriod=14d
- https://new-sentry.gitlab.net/organizations/gitlab/issues/220349/?environment=gprd&project=4&query=Blocked+%27connect%27+from&referrer=issue-stream&sort=freq&statsPeriod=14d
Output of checks
This bug happens on GitLab.com
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
We'd need to do something similar to !71243 (diffs) where a concern was created for the CSP and then we include it in the relevant controllers.