Fix danger/roulette/Dangerfile for remote development group
MR: Fix danger/roulette/Dangerfile for remote devel... (!126060 - merged)
Description
The following discussion from !125355 (merged) should be addressed:
-
@cwoolley-gitlab started a discussion: (+1 comment)
Regarding the problems with the remote development Danger roulette handling mentioned here: !125355 (comment 1465036935)
This is because the rules in the roulette
Dangerfile
are out of date (actually have always been wrong), and do not match the recent changes toCODEOWNERS
.The Dangerfile entry refers to the @gitlab-org/remote-development group, but that was incorrect when it was originally introduced, because that group contains no members (hence the errors).
CODEOWNERS
now manages the backend and frontend maintainers as separate groups:- @gitlab-org/maintainers/remote-development/backend
- @gitlab-org/maintainers/remote-development/frontend
So, we need to update the
Dangerfile
NOT_AVAILABLE_TEMPLATES
entry to use this backend group.The only reason that this custom
Dangerfile
template forremote_development
exists is so we don't get tagged fortooling
reviews when we update our files underscripts/remote_development
: https://gitlab.com/gitlab-org/gitlab/-/blob/921963ce44ae25b8a9d24e2617dc1ad46aa19ff6/tooling/danger/project_helper.rb#L118-118I'll make a separate MR to fix this.
Acceptance Criteria
-
Dangerfile updated -
tooling/danger/project_helper.rb
updated