Skip to content

Remove rescue block in spec/features/merge_request/user_edits_mr_spec.rb and shared examples called in that file

The following discussion from !125189 (merged) should be addressed:

  • @splattael started a discussion: (+6 comments)

    Question (non-blocking) I am seeing this exception being only used once in the main branch: spec/support/shared_examples/features/content_editor_shared_examples.rb.

    Why do we need to rescue them?

    Let's discuss/follow-up on that later though 💪

    Additional note from @jay_mccure:

    • From what I can tell this visit edit_project_merge_request_path(target_project, merge_request) (and surrounding block) isn't even necessary for the test. Even in master removing this and !125189 (diffs) and then running spec/features/merge_request/user_edits_mr_spec.rb still passes.

      I think this is because spec/support/shared_contexts/merge_request_edit_shared_context.rb visits the same page, so the above is effectively refreshing the page, and thus causing the alert.