Follow-up from "[Feature flag] Cleanup `audit_event_group_rollup`"
The following discussion from !123739 (merged) should be addressed:
-
@OmarQunsulGitlab started a discussion: (+7 comments) @wandering_person I was curious about the result of this MR. I checked on postgres.ai, and it seems that the indexes are still on the partitions. See this for example
\d+ gitlab_partitions_dynamic.audit_events_202305 .... "index_571aaf4cf4" btree (entity_id, entity_type, created_at, id) ...
When I was trying to drop it on postgres.ai, I get this error:
exec drop index gitlab_partitions_dynamic.index_571aaf4cf4 Session: webui-i20193 ERROR: ERROR: cannot drop index gitlab_partitions_dynamic.index_571aaf4cf4 because index index_audit_events_on_entity_id_and_entity_type_and_created_at requires it (SQLSTATE 2BP01)
So apparently we have to drop the index on the parent table first, then try again?
Can you double check as well? maybe I have missed something.
CC: @l.rosa
Implementation Plan
-
Use prepare_async_index_removal
on each partition -
when prepare_async_index_removal
is done drop the index from theaudit_events
table with a post migration.- (should be almost a no-op since there are no underlying indexes in the partitions)
Edited by Michael Becker