Improve the error message signature in GitLab Duo Chat
The following discussion from !127235 (merged) should be addressed:
-
@dmishunov started a discussion: (+3 comments) question: @timzallmann shouldn't we send something like
errors[0]
in this case?🤔 I just architectually don't understand what are the cases when we senderror
, but at the same time providecontent
. Why would we confuse the things? If there's an error, we senderrors
, if there's no error, we sendcontent
🤔 > so we could send a specific message for an error but might provide more info in the error array,
I'm wondering why not to structure
errors
differently in this case? Is there any technical reason to not senderrors
like the example below or something similar to account for optional additional details for every error we decide to return?errors: [ { message: 'Something descriptive', details: { ... // whatever we need to send in addition to this particular error } } ]
Edited by Denys Mishunov