Super sidebar logged-in specs: Change specs to work with new sidebar

What?

We are planning to make the super sidebar navigation the default navigation. Unfortunately we currently rely on the old navigation behavior in more than 150 spec files. Currently the old navigation is used in all specs. So far we have done:

1. Introduce a user specific trait and move from a global "old"-nav switch to a per-test switch:
   • Introducing the trait !130148 (merged)
   • At least three more MRs: !130151 (merged), !130301 (merged), !130302 (merged)
   • Switch to local disable of new nav: !126175 (merged)
2. Remove the global feature flag toggle

Now we need to do:

1. Fix all tests to work with the new nav: #420121 (closed)
2. Remove the trait TBA

How?

1. Pick one or (more related specs from the sheet), add your name to the Who? column
   • Similar to button migrations, use some common sense when it comes to picking up multiple specs in one MR.
   • Side-note: spec/features only needs QA review!
2. Remove :no_super_sidebar trait from the specs
3. Fix them
4. Mark them as done once the MR is merged

I think the specs fall into these categories:

1. Easy fix by fixing some css selectors
2. Spec can be removed because they tested an old-nav behavior that isn't here anymore
3. Controller specs: There are a few controller specs that guard against N+1 queries. Ignore them for now. I believe they will be fixed once we remove the toggle.
4. Integration Specs of the old nav, see this discussion: #420121 (comment 1605392857)
5. 🐲 🐉 🐲