UI Broken Integration with Deployment Approvals for Inherited Users

Summary

When adding groups to a protected environments, only directly added members of groups were being included in the rules. There's no option to change that in the UI. Neither deployment approvals or enabled deployers utilize group inheritance. When using the api to validate the entries, the same results reign true -- both deployers and approvers have group_inheritance_type set to 1, but the UI does not show inherited users.

Steps to Reproduce

Attempt to add group to a protected environment with group_inheritance_type set to 1
Review groups in UI, which will show that they are not inheriting users

What is the current bug behavior?

Regardless of group_inheritance_type set to 1, the list of users in "Allowed to Deploy/Approve" in Protected Environment settings only show direct members. It doesn't show inherited members.

What is the expected correct behavior?

Inherited members to be included in settings.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info


(For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:env:info\`) (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\`)

Results of GitLab application Check

Expand for output related to the GitLab application check


(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`)

(For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)

(we will only investigate if the tests are passing)