Follow-up from "Adding decompress_archive_file_timeout to application settings"
The following discussion from !129161 (merged) should be addressed:
-
@cwoolley-gitlab started a discussion: (+4 comments) suggestion (non-blocking) It doesn't look like this constructor argument is ever used to override the value, we always use the default from the settings.
Can we eliminate it and the
@timeout
instance variable, and just useself.timeout
directly in the call toTimeout.timeout
?The same is true of
max_bytes
, it could be removed too.