Color severity status color on Security Dashboard seems incorrect in Dark Mode
Summary
When you look at the security dashboard in dark mode, the project security status color indicator seems off compared to light mode. See screenshot section. "F" is highlighted as red in light mode where dark mode is highlighted as white.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
GitLab.com and Self-Managed
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Proposal
Update from gl-text-red-900
to gl-text-red-800
. This will make it consistent with the critical
color on the project vulnerability report.
Current | Proposal |
---|---|
gl-text-red-900 |
gl-text-red-800 |
See this discussion for more info > #423575 (comment 1545297814)
Implementation Guide
- In order to run a pipeline to generate a Vulnerability report, you'll need an EE license.
- Fork https://gitlab.com/gitlab-examples/security/security-reports/
- Run a pipeline against the default branch. It will generate vulnerabilities.
- View the project security status for a group > Docs
- Adjust the color setting in
ee/app/assets/javascripts/security_dashboard/components/shared/project_security_status_chart.vue