Follow-up from "Create a reusable helper for invite feature specs"
The following discussion from !131044 (merged) should be addressed:
-
@dstull started a discussion: (+5 comments) suggestion (non-blocking):
This is great, what do you think about either in this MR or a follow-up applying it to all the other places in feature specs where we do this?
For example in
ee/spec/support/helpers/saas_registration_helpers.rb
we could use it like this:def user_signs_up_through_trial_registration new_user = build(:user, name: 'Registering User', email: user_email) fill_in_sign_up_form(new_user, 'Continue') end
Context:
nice work - there are a few in sign up spec files still, but I don't think those really 'look' the same or are the same enough.
A few more cases in
ee/spec/features/google_analytics_datalayer_spec.rb
, but we can handle those in a follow-up
Edited by Ross Byrne