Follow-up from "Remove welcome onboarding step from non SaaS"
The following discussion from !130335 (merged) should be addressed:
-
@nicolasdular started a discussion: (+1 comment) thought (non-blocking): This highlights why I am not in favour of concerns. We need to implement a
private
methodonboarding_status
in our controller because we added a concernOnboarding::Redirectable
. Just from looking at this controller code I don't know- Why it's implemented
- How it gets used
I know this might be the "Rails-way", but maybe worth a wider engineering discussion in the future to limit the usage.
e.g. if we'd have a
Onboarding::Redirect
object that does the same as theRedirectable
concern, it would be more explicit and easier to test.