Remove all references to `deployments.cluster_id`
Context
The reference to deployments.cluster
is now delegated through the deployment_clusters
association table. As a follow-up, we need to remove all references to deployments.cluster_id
. In some cases, we need to replace with those with deployments.deployment_cluster
.
Other related issue: #202628 (closed)
Proposal
-
In app/services/deployments/create_service.rb
- do not set
deployments.cluster_id
- create
deployments.deployment_cluster
instead
- do not set
-
In app/services/deployments/create_for_job_service.rb
- do not set
deployments.cluster_id
- do not set
-
In app/models/clusters/cluster.rb
- remove
has_many successful_deployments
relationship; this is not used anywhere
- remove
The Draft/POC MR !133671 (closed) shows that ignoring cluster_id
will only result in a successful pipeline if references to cluster_id
(or the direct clusters <=> deployments
connection) are removed in the above files
Edited by Pam Artiaga