Follow-up from "Add GitHub identifiers to all exceptions from import classes"
The following discussions from !133273 (merged) should be addressed:
-
@drew started a discussion: I had a chat with @rodrigo.tomonari, and we think this might be duplicative with this attribute also being saved in the
ImportFailureService
? Orperform_failure
might be handling the non-caught exception cases, in which having this here also makes sense. -
@drew started a discussion: I see this be included in some expectation calls, but I couldn't find any spec asserting that this actually gets written to the database in the way we expect it to. Again, I talked about this with @rodrigo.tomonari and we see that it is working, but a spec asserting that we do in fact write to the column when we expect to should be helpful.