Add rubocop cop to lint format of the rubocop inline disabling
From !134385 (comment 1607081608) we want to explore creating a rubocop that will alert on improperly formatted inline rubocop disabling if there is no comment. We added the docs to back this style up in !134385 (merged)
# bad
module Types
module Domain
# rubocop:disable Graphql/AuthorizeTypes
class SomeType < BaseObject
object.public_send(action) # rubocop:disable GitlabSecurity/PublicSend
end
# rubocop:enable Graphql/AuthorizeTypes
end
end
# good
module Types
module Domain
# rubocop:disable Graphql/AuthorizeTypes -- already authorized in parent entity
class SomeType < BaseObject
# At this point `action` is safe to be used in `public_send`.
# See https://gitlab.com/gitlab-org/gitlab/-/issues/123457890.
object.public_send(action) # rubocop:disable GitlabSecurity/PublicSend -- User input verified
end
# rubocop:enable Graphql/AuthorizeTypes
end
end
Edited by Peter Leitzen