Resolve duplicate Value Stream Dashboards listed in group-level analytics dashboard page
Problem to solve
With Decouple dashboards frontend from product analy... (!134077 - merged) the Group > Analytics Dashboards page lists two Value Stream Dashboards:
- One fetched from GraphQL.
- One hardcoded as a temporary measure that links to the dedicated VSD page.
Note: The Group > Analytics Dashboards page is hidden behind a default off group_analytics_dashboard
feature flag.
See the discussion !134077 (comment 1620213021) for more context.
Screenshot
Possible solutions
Original plan
A possible solution was commented by @ekigbo:
So I think removing that line and relying on the graphql result when we render the dashboard listing makes sense (a separate MR is fine if thats preferred). I'm not sure if that's what you meant in point
3️⃣ , so apologies if it is! If we remove that link, this would mean the behaviour would be:
group_analytics_dashboard
enabled -> render the dashboard listing and fetch the config from graphqlgroup_analytics_dashboard
disabled -> current behaviour (link directly to the old "Hardcoded" VSD page)
Solution
Introduce 2 new feature flags to control VSD:
-
group_analytics_dashboard_dynamic_vsd
- toggle between the hardcoded VSD and the shared dashboard VSD -
project_analytics_dashboard_dynamic_vsd
- enable the project level vsd: this will occur in Project VSD within shared dashboards - behind i... (#429541 - closed)
Edited by Ezekiel Kigbo