Follow-up from "Enable group level vulnerability report grouping"
The following discussion from !137778 (merged) should be addressed:
-
@dpisek started a discussion: (+2 comments) question: It looks like we are not testing the case of
groupLevelVulnerabilityReportGrouping
to befalse
.Maybe something for a follow-up?
🤔 PS.: I took a stab at it, just to make sure everything is OK. Here is what I came up with, perhaps you can somehow use it, so it doesn't go to waste
😅 diff --git a/ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_report.vue b/ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_report.vue index 36b0451ccead..ce703465e18f 100644 --- a/ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_report.vue +++ b/ee/app/assets/javascripts/security_dashboard/components/shared/vulnerability_report/vulnerability_report.vue @@ -114,6 +114,10 @@ export default { return this.filterDropdowns.includes(FILTERS.PROJECT); }, shouldShowGroupByButton() { + console.log( + this.isGroupVulnerabilityReport, + this.glFeatures.groupLevelVulnerabilityReportGrouping, + ); if (!this.isVisible) { return false; } diff --git a/ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_report_spec.js b/ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_report_spec.js index 9e879f1be7cc..a489a6bcb15d 100644 --- a/ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_report_spec.js +++ b/ee/spec/frontend/security_dashboard/components/shared/vulnerability_report/vulnerability_report_spec.js @@ -85,6 +85,7 @@ describe('Vulnerability report component', () => { const findFilters = () => wrapper.findComponent(VulnerabilityFilters); const findList = () => wrapper.findComponent(VulnerabilityListGraphql); const findListTopDiv = () => wrapper.findByTestId('vulnerability-list-top'); + const findGroupByButton = () => wrapper.findComponent(GlCollapsibleListbox); describe('counts', () => { it.each([true, false])('shows/hides the counts', (showCounts) => { @@ -235,7 +236,6 @@ describe('Vulnerability report component', () => { }; const findNewFeaturePopover = () => wrapper.findComponent(GlPopover); - const findGroupByButton = () => wrapper.findComponent(GlCollapsibleListbox); const findSummaryHighlights = (groupValue) => wrapper.findByTestId(`summary-highlights-${groupValue}`); const findGroupHeader = (groupValue) => @@ -603,4 +603,21 @@ describe('Vulnerability report component', () => { ); }); }); + + describe('with group level vulnerability report grouping feature flag disabled', () => { + beforeEach(() => { + createWrapper({ + isVisible: true, + isGroupVulnerabilityReport: true, + isProjectVulnerabilityReport: false, + glFeatures: { + groupLevelVulnerabilityReportGrouping: false, + }, + }); + }); + + it('should not show the group by dropdown', () => { + expect(findGroupByButton().exists()).toBe(false); + }); + }); });