Skip to content

Audit event for "allowed to push and merge" name inaccurate

Summary

Customer reports that if you change the "allowed to push and merge" value for a protected branch that the related audit event only says "allowed to push", even though it's the push and merge permission.

It's otherwise correct, it's just a slight inaccuracy in the name of the event.

Steps to reproduce

  • Change any protected branch to alter the "allowed to push and merge" section
  • In the audit events note that the name of the related event is missing "and merge" from the label

Relevant logs and/or screenshots

This is what the audit event looks like when you change the "push and merge" section.

Audit event after changing "allowed to push and merge"

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

n/a - reproduced on .com, customer is on 16.7

Possible fixes

I think it may just need changed in here? https://gitlab.com/gitlab-org/gitlab/-/blob/ceb94405ecab6e096fc88f4ad6ffad8a2e1c794f/ee/lib/audit/protected_branches_changes_auditor.rb#L29