Regression on pasting image from clipboard and code indentation in Rich Text Editor
Summary
I think I found a regression on gitlab docker gitlab/gitlab-ce:16.7.0-ce.0
(and the ee version), found on fresh installation
- I cant paste image from clipboard into Rich Text Editor, no error, but I can when using plain text editor
- The code block has wrong indentation when pasting (in which I also have problem when pasting below docker compose code) (present on gitlab.com)
such problem doesnt exist on plain text editor, and from previous version gitlab/gitlab-ce:16.6.0-ce.0
Steps to reproduce
- Use this docker compose file
version: '3.6'
services:
gitlab:
image: 'gitlab/gitlab-ce:16.7.0-ce.0'
restart: always
hostname: 'localhost'
environment:
GITLAB_LOG_LEVEL: warn
GITLAB_OMNIBUS_CONFIG: |
external_url 'http://localhost'
letsencrypt['enable'] = false
nginx['listen_port'] = 80
nginx['listen_https'] = false
ports:
- "80:80"
volumes:
- './.dockerdata/gitlab/config:/etc/gitlab'
- './.dockerdata/gitlab/logs:/var/log/gitlab'
- './.dockerdata/gitlab/data:/var/opt/gitlab'
shm_size: '256m'
- Login with root
- Create blank project
- Create issue, on the description change to Rich Text Editor
- Now paste image from clipboard
- Observe the issue present
- Now try creating code block
-
Paste sample code with indentation into the code block
-
Observe the code now has 0 indent, all left, like this
version: '3.6' services: gitlab: image: 'gitlab/gitlab-ce:16.7.0-ce.0' restart: always hostname: 'localhost' environment: GITLAB_LOG_LEVEL: warn GITLAB_OMNIBUS_CONFIG: | external_url 'http://localhost' letsencrypt['enable'] = false nginx['listen_port'] = 80 nginx['listen_https'] = false ports: - "80:80" volumes: - './.dockerdata/gitlab/config:/etc/gitlab' - './.dockerdata/gitlab/logs:/var/log/gitlab' - './.dockerdata/gitlab/data:/var/opt/gitlab' shm_size: '256m'
-
Example Project
-
What is the current bug behavior?
- I cant paste image from clipboard into Rich Text Editor, no error, but it works when using plain text editor
- The code block has wrong indentation when pasting
What is the expected correct behavior?
- Can paste image from clipboard into rich text editor
- Can paste code into code block with correct indentation
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information
System:
Current User: git
Using RVM: no
Ruby Version: 3.1.4p223
Gem Version: 3.4.22
Bundler Version:2.4.22
Rake Version: 13.0.6
Redis Version: 7.0.14
Sidekiq Version:6.5.12
Go Version: unknown
GitLab information
Version: 16.7.0
Revision: 0fb7483d0df
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 14.9
URL: https://git3.unpad.dev
HTTP Clone URL: https://git3.unpad.dev/some-group/some-project.git
SSH Clone URL: git@git3.unpad.dev:some-group/some-project.git
Using LDAP: no
Using Omniauth: yes
Omniauth Providers:
GitLab Shell
Version: 14.32.0
Repository storages:
- default: unix:/var/opt/gitlab/gitaly/gitaly.socket
GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Gitaly
- default Address: unix:/var/opt/gitlab/gitaly/gitaly.socket
- default Version: 16.7.0
- default Git Version: 2.42.0
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 14.32.0 ? ... OK (14.32.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Internal API available: OK
Redis available via internal API: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes (cluster/worker) ... 1/1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Database config exists? ... yes
Tables are truncated? ... skipped
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Cable config exists? ... yes
Resque config exists? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units)
Projects have namespace: ...
1/1 ... yes
Redis version >= 6.0.0? ... yes
Ruby version >= 3.0.6 ? ... yes (3.1.4)
Git user has default SSH configuration? ... yes
Active users: ... 1
Is authorized keys file accessible? ... yes
GitLab configured to store new projects in hashed storage? ... yes
All projects are in hashed storage? ... yes
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
Edited by iqbal, fikri m