FE: Support new policy action type `send_bot_message`
Why are we doing this work
Policy bot comment may be overwhelming for some users and we would like to give users option to disable it. By default, it should be enabled when users create new policies and it should stay enabled by default for older policies that do not have this new action specified in the YML.
Relevant links
Non-functional requirements
-
Feature flag: Implement the new behavior behind a feature flag
Implementation plan
-
Add a new action type send_bot_message
in the action section. The new action should be shown by default. -
Add a collapsible section for Example message
with a preview of the bot comment -
When the action is removed, the YAML should be updated to the following: actions: - type: send_bot_message enabled: false
-
If there's no action with type: send_bot_message
, it should be displayed the same way as withenabled: true
-
!149931 (comment 1872323675) -
!149931 (comment 1872323688)
Number | Description | MR |
---|---|---|
1 | Creates skeleton structure | Create bot comment action (!149931 - merged) |
2 | Allow adding bot comment action in rule mode and add yaml validation | Add functionality for bot message action (!150570 - merged) |
3 | Update behavior around removing the send_bot_message action |
Update rule mode for bot message action (!151464 - merged) |
4 | Complete design of bot comment action | Add example bot message to action (!151615 - merged) |
5 | Update yaml validation and alert behavior | Update yaml validation for actions (!151697 - merged) |
Verification steps
- Create a new Scan Result Policy
- Ensure that "Send a bot message" action is visible and the YAML reads:
actions:
- type: send_bot_message
enabled: true
- Remove the action and ensure the YAML is updated to:
actions:
- type: send_bot_message
enabled: false
- Go to the
.yaml mode
, remove the action and go back to the rule mode. Ensure the action is visible.
Edited by Alexander Turinske