Fix Workhorse linter warnings (part 34)
Problem
make golangci
linter detects warnings in following Workhorse files
How to verify
make golangci | grep -E "^internal/upstream/(devel|hand|metr|notfound|round|routes)"
internal/upstream/development_test.go:1:1: package-comments: should have a package comment (revive)
internal/upstream/handlers.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/upstream/handlers.go:32:19: Error return value of `body.Close` is not checked (errcheck)
internal/upstream/metrics.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/upstream/metrics.go:32:41: unused-parameter: parameter 'method' seems to be unused, consider removing or renaming it as _ (revive)
internal/upstream/metrics.go:36:49: unused-parameter: parameter 'method' seems to be unused, consider removing or renaming it as _ (revive)
internal/upstream/notfoundunless.go:10:9: wrapperFunc: use http.NotFoundHandler method in `http.HandlerFunc(http.NotFound)` (gocritic)
internal/upstream/notfoundunless.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/upstream/notfoundunless.go:5:1: exported: exported function NotFoundUnless should have comment or be unexported (revive)
internal/upstream/roundtripper/roundtripper.go:1:1: package-comments: should have a package comment (revive)
internal/upstream/roundtripper/roundtripper.go:44:2: ifElseChain: rewrite if-else to switch statement (gocritic)
internal/upstream/routes.go:141:68: `(*upstream).wsRoute` - `matchers` always receives `nil` (unparam)
internal/upstream/routes.go:1:1: ST1000: at least one file in a package should have a package comment (stylecheck)
internal/upstream/routes.go:201: Function 'configureRoutes' is too long (233 > 60) (funlen)
internal/upstream/routes.go:373: internal/upstream/routes.go:373: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "TODO: We should probably not return a HT..." (godox)
internal/upstream/routes.go:389: internal/upstream/routes.go:389: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "Note that Geo already redirects pushes, ..." (godox)
internal/upstream/routes.go:390: internal/upstream/routes.go:390: Line contains TODO/BUG/FIXME/NOTE/OPTIMIZE/HACK: "Note that excessive secondary lag can ca..." (godox)
Solution
Resolve warnings
Edited by Vasilii Iakliushin