Improve diff colors for "None" syntax highlighting theme
Release notes
Improve diff colors for "None" syntax highlighting theme.
Problem to solve
For both default and custom diff colors for the "None" syntax highlighting theme, the background color of the changed file code lines remains gray. The original file takes on the custom color. I find the green / red diff to be very helpful in reviewing, but it doesn't work well with the "None" theme for syntax highlighting.
Proposal
For custom colors, change the background color of the changed file lines to equal the same color as the background color of the changed file line numbers.
In addition, it would be really nice to have the default diff colors for the "None" syntax highlighting theme be the same red / green from the light theme (basically, light theme without syntax highlighting). I'm not sure if this suggestion will be picked up, though. It would follow what the documentation currently states about diff colors:
Diffs use two different background colors to show changes between versions of code. By default, the original file is in red, and the changes are in green.
My browser inspector is telling me it might be due to this line of CSS, which only applies to the changed file side of the diff (appears to come from the none theme CSS file):
.code.none .line_holder .line_content.new:not(.hll),.code.none .line_holder .line_content.new-nomappinginraw:not(.hll) {
background-color: #ececef;
}
Before | After |
---|---|
Intended users
Developers, mostly.
Feature Usage Metrics
I don't think this is applicable.
Does this feature require an audit event?
I don't think so.