[Bug] Timestamps are being converted to delimited numbers in product analytics tables
Summary
With Use delimiters when displaying numeric values i... (#427217 - closed) we enabled delimiters for numerical values. The problem is that this is also picking up timestamps as numerical values too.
So when you create a table which contains timestamps, it will show the delimited year rather than the full timestamp.
Steps to reproduce
- Visit the visualization designer for a product analytics enabled project:
[GROUP]/[PROJECT]/-/analytics/dashboards/visualization-designer
. - Create a new visualization using the Data table visualization type.
- Add a measure with some data.
- Set the Events over time dropdown to group by a time dimension.
- View the visualization and see the timestamp is incorrect.
Example Project
What is the current bug behavior?
Timestamps are converted to numbers and delimited.
What is the expected correct behavior?
Timestamps are rendered as timestamps. It is fine to go back to the old behaviour of being basic strings rather than formatting the timestamps for now.
Relevant logs and/or screenshots
Incorrect | Correct |
---|---|
Implementation plan
frontend -
- Update
formatValue
to use theisValidDateString
util to check if it's a timestamp before checking if it's numerical. - Add tests to check it works as expected.