Audit and update SaaS checks in Product Analytics code
Overview
During the development of the Product Analytics beta, we only supported SaaS. Therefore there are checks that make Product Analytics is only visible for GitLab.com users.
Now we are moving to support bring-your-own-cluster, we need to ensure that none of the existing checks in the codebase will prevent non-SaaS customers from bringing their own cluster.
Implementation plan
- Audit the product analytics feature-set for any checks that would prevent non-SaaS users from setting up and instrumenting projects with product analytics.
- Remove any such checks.
- Make sure any SaaS-specific specs are updated.
Unpicking experiment/beta features toggle
One specific thing that needs fixing is our reliance on the SaaS-only "Use Experiment and Beta features" checkbox in a root namespace's settings. We're going to do the following:
- Enable SM instances to enable this toggle as the
Use Product Analytics
checkbox depends on it. - Delete the
Use Product Analytics
checkbox globally and rely only on theExperiment and Beta Features
checkbox to enable PA. - Since we're going to GA in this milestone, remove the check for "Use Experiment and Beta features" anyway (/cc @dennis, is this correct?)
Edited by Max Woolf