Validation does not happen when project is changed

Summary

When validation fails for external file, if user changes the project after that, validation does not work any more.

Steps to reproduce

1. Upload a GitLab Ultimate license
2. Enable the feature flag echo "Feature.enable(:compliance_pipeline_in_policies)" | rails c.
3. Create a group => Settings => General => Permissions and group features section
4. Enable Run customized CI YAML file as security policy actions and save
5. Navigate to a project => Create a .yml file in it
6. Navigate to a project in the group => Secure => Policies => New policy => Scan Execution Policy
7. Add new action => Run CI/CD code => Run "Linked existing CI file"
8. Select the current project and the branch with the .yml file
9. Mistype the file name
10. Verify the validation fails (the ref and file name inputs are outlined in red)
11. Type in the correct file name
12. Verify the validation succeeds (nothing is outlined in red)
13. Change the branch to one without the .yml file
14. Verify the validation fails (the ref and file name inputs are outlined in red)
15. Change project validation does not happen

no validation.mov

Example Project

What is the current bug behavior?

What is the expected correct behavior?

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

(For installations with omnibus-gitlab package run and paste the output of: \`sudo gitlab-rake gitlab:env:info\`) (For installations from source run and paste the output of: \`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production\`)

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`)

(For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`)

(we will only investigate if the tests are passing)

Analysis

What is happening is

• when a user switches projects, the ref gets reset to default branch
• we do not currently retrieve what the default branch is for a project, so no validation is done against it (code)

Possible solution

• retrieve default branch when project is selected and use it for validation