Convert redis counts for group::code_review
Problem
There are metrics for groupcode review which are still based on Redis total counts and should be converted to Internal Events.
Desired Outcome
The following metrics are converted to internal events:
- 20210216175041_merge_request_comment.yml
- 20210216175043_merge_request_create.yml
- counts.i_code_review_merge_request_widget_accessibility_count_expand
- counts.i_code_review_merge_request_widget_accessibility_count_expand_failed
- counts.i_code_review_merge_request_widget_accessibility_count_expand_success
- counts.i_code_review_merge_request_widget_accessibility_count_expand_warning
- counts.i_code_review_merge_request_widget_accessibility_count_full_report_clicked
- counts.i_code_review_merge_request_widget_accessibility_count_view
- counts.i_code_review_merge_request_widget_code_quality_count_expand
- counts.i_code_review_merge_request_widget_code_quality_count_expand_failed
- counts.i_code_review_merge_request_widget_code_quality_count_expand_success
- counts.i_code_review_merge_request_widget_code_quality_count_expand_warning
- counts.i_code_review_merge_request_widget_code_quality_count_full_report_clicked
- counts.i_code_review_merge_request_widget_code_quality_count_view
- counts.i_code_review_merge_request_widget_license_compliance_count_expand
- counts.i_code_review_merge_request_widget_license_compliance_count_expand_failed
- counts.i_code_review_merge_request_widget_license_compliance_count_expand_success
- counts.i_code_review_merge_request_widget_license_compliance_count_expand_warning
- counts.i_code_review_merge_request_widget_license_compliance_count_full_report_clicked
- counts.i_code_review_merge_request_widget_license_compliance_count_view
- counts.i_code_review_merge_request_widget_metrics_count_expand
- counts.i_code_review_merge_request_widget_metrics_count_expand_failed=
- counts.i_code_review_merge_request_widget_metrics_count_expand_success
- counts.i_code_review_merge_request_widget_metrics_count_expand_warning
- counts.i_code_review_merge_request_widget_metrics_count_full_report_clicked
- counts.i_code_review_merge_request_widget_metrics_count_view
- counts.i_code_review_merge_request_widget_security_reports_count_expand
- counts.i_code_review_merge_request_widget_security_reports_count_expand_failed
- counts.i_code_review_merge_request_widget_security_reports_count_expand_success
- counts.i_code_review_merge_request_widget_security_reports_count_expand_warning
- counts.i_code_review_merge_request_widget_security_reports_count_full_report_clicked
- counts.i_code_review_merge_request_widget_security_reports_count_view
- counts.i_code_review_merge_request_widget_status_checks_count_expand
- counts.i_code_review_merge_request_widget_status_checks_count_expand_failed
- counts.i_code_review_merge_request_widget_status_checks_count_expand_success
- counts.i_code_review_merge_request_widget_status_checks_count_expand_warning
- counts.i_code_review_merge_request_widget_status_checks_count_full_report_clicked
- counts.i_code_review_merge_request_widget_status_checks_count_view
- counts.i_code_review_merge_request_widget_terraform_count_expand
- counts.i_code_review_merge_request_widget_terraform_count_expand_failed
- counts.i_code_review_merge_request_widget_terraform_count_expand_success
- counts.i_code_review_merge_request_widget_terraform_count_expand_warning
- counts.i_code_review_merge_request_widget_terraform_count_full_report_clicked
- counts.i_code_review_merge_request_widget_terraform_count_view
- counts.i_code_review_merge_request_widget_test_summary_count_expand
- counts.i_code_review_merge_request_widget_test_summary_count_expand_failed
- counts.i_code_review_merge_request_widget_test_summary_count_expand_success
- counts.i_code_review_merge_request_widget_test_summary_count_expand_warning
- counts.i_code_review_merge_request_widget_test_summary_count_full_report_clicked
- counts.i_code_review_merge_request_widget_test_summary_count_view
Potential Solutions
Check the steps mentioned in #433107 (comment 1856588406) to do the migration.
Use the migration solution from #429556 (closed). Please be on the lookout for already existing events which might have been instrumented to track the same action and are in use by a unique or similar metric
Consider if it is possible to additional properties and make lesser events, If that's the case then we should do it after #435338 (closed)
Potential event:
track_internal_event(
'expand_merge_request_widget',
project: project,
namespace: project.namespace,
user: user,
additionalProperties: {
label: 'test_summary',
property: 'success'
}
)
How to verify
Migrated events should show the appropriate values in the newest automated service ping, e.g. on this dashboard with install id 8b52effca410f0a380b0fcffaa1260e7