Backend: Update feature_category to category:pipeline composition for Pipeline Creation endpoints
Summary
As proposed and discussed in verify-stage#554 (closed), currently, grouppipeline authoring owns most of the logic in Ci::CreatePipelineService
since the majority of it is about building a pipeline from CI configurations.
Additionally, grouppipeline authoring owns the CI Linter endpoint. The linter is logic used in great part by Ci::CreatePipelineService
. Yet, grouppipeline execution is responsible for the error budget of all pipeline creation endpoints.
Proposal
Assign feature_category :pipeline_composition
to all endpoints responsible for the pipeline creation:
RunPipelineScheduleWorker
PipelinesController#create
CreatePipelineWorker
Ci::ExternalPullRequests::CreatePipelineWorker
MergeRequests::CreatePipelineWorker
POST /trigger/pipeline
POST /pipeline
POST /merge_requests/:mr_id/pipelines
grouppipeline authoring covers pipeline_composition
. Arguably, assembling a pipeline (creation) is also pipeline_composition
.
Confirm purpose and User Reception (how does this benefit the user?)
No user impact but it will better align our endpoints to be owned by grouppipeline authoring since the team maintains the logic in Ci::CreatePipelineService
already.
The biggest benefit is that it provides more structure around endpoint support which makes triaging more efficient in the future.
Additional details
Some relevant technical details, if applicable, such as:
- Does this need a feature flag?
- Does there need to be an associated instrumentation issue created related to this work?
- Is there an example response showing the data structure that should be returned (new endpoints only)?
- What permissions should be used?
- Is this EE or CE?
-
EE -
CE
-
- Additional comments: