Learn GitLab 'Add code' task completion qualification audit
Currently we base 'Add code' completion on these 2 possibilities defined here:
-
repository.commit_count > 1
: If there is more than one commit in the repo, then we can be sure that commit has a file that was submitted with it or changed by it, else the commit wouldn't be valid. -
repository.branch_count > 1
: More than the default repo exists. This can only exist once we have added a file due to the check here.
However, what this does not cover is the import of a project or the adding of code via a project template since it imports as well. This was uncovered during investigation in Creating a project with a template should compl... (#454578 - closed).
Solution
Consider import of a project/applying of a template to be a completion of Add code
as well since we are satisfying the task of adding code when importing code.
We could accomplish this perhaps by adding the following code in the same area:
return unless repository.commit_count > 1 || repository.branch_count > 1 || repository.ls_files(project.default_branch).any?