Skip to content

Fix quarantined flaky test for hash ordering instability

MR: FIx hash ordering stability that causes test to... (!153696 - merged)

Description

Possible issue - !151854 (comment 1891966635)

The following discussion from !151854 (merged) should be addressed:

  • @vtak started a discussion: (+1 comment)

    @cwoolley-gitlab @adebayo_a - FYI

    @cwoolley-gitlab - @adebayo_a I think we know the cause of this (hash ordering instability, described in my comment below).

    So, we should:

    1. Go ahead and merge this MR to disable/quarantine the test (and lose the test coverage it gives us).
    2. Make a separate issue to fix this ordering problem, and prioritize it highly.
    3. Make a separate issue to re-enable this test (i.e. revert this MR) once we fix the problem (so we don't forget to re-enable the test), and make it blocked by the issue to fix it. Alternately, just make the re-enabling a task on the fix issue, but we need to make sure we don't forget to re-enable. Maybe there's other tooling to remind us of quarantined specs and we don't need to worry this much, I don't know.

[Provide any additional description here.]

Acceptance Criteria

Technical Requirements

TODO: Fill out or delete (optional) [If applicable, please list out any technical requirements for this feature/enhancement.]

Design Requirements

TODO: Fill out or delete (optional) [If applicable, please provide a link to the design specifications for this feature/enhancement.]

Impact Assessment

TODO: Fill out or delete (optional) [Please describe the impact this feature/enhancement will have on the user experience and/or the product as a whole.]

User Story

TODO: Fill out or delete (optional) [Provide a user story to illustrate the use case for this feature/enhancement. Include examples to help communicate the intended functionality.]

Edited by Safwan Ahmed